From f9a14959a5f0bef794c482c8a7fffc83b4e5c19b Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Wed, 29 Aug 2007 15:30:47 +0000 Subject: [PATCH] Revert schema change in r25267 -- no more schema changes right before release please. --- includes/Article.php | 4 ++-- .../archives/patch-revision-user-page-index.sql | 5 ----- maintenance/tables.sql | 3 +-- maintenance/updaters.inc | 15 +-------------- 4 files changed, 4 insertions(+), 23 deletions(-) delete mode 100644 maintenance/archives/patch-revision-user-page-index.sql diff --git a/includes/Article.php b/includes/Article.php index 040a905868..5bb5915eb3 100644 --- a/includes/Article.php +++ b/includes/Article.php @@ -2461,8 +2461,8 @@ class Article { * * @param Revision $rev * - * @todo This is a lousy interface function. Kill it and replace the - * other cruddy functions like editUpdates and such so it's not needed + * @todo This is a shitty interface function. Kill it and replace the + * other shitty functions like editUpdates and such so it's not needed * anymore. */ function createUpdates( $rev ) { diff --git a/maintenance/archives/patch-revision-user-page-index.sql b/maintenance/archives/patch-revision-user-page-index.sql deleted file mode 100644 index 9058e4e9fc..0000000000 --- a/maintenance/archives/patch-revision-user-page-index.sql +++ /dev/null @@ -1,5 +0,0 @@ --- New index on revision table to allow searches for all edits by a given user --- to a given page. Added 2007-08-28 - -ALTER TABLE /*$wgDBprefix*/revision - ADD INDEX page_user_timestamp (rev_page,rev_user,rev_timestamp); diff --git a/maintenance/tables.sql b/maintenance/tables.sql index d23dc48316..7477e5bea0 100644 --- a/maintenance/tables.sql +++ b/maintenance/tables.sql @@ -282,8 +282,7 @@ CREATE TABLE /*$wgDBprefix*/revision ( INDEX rev_timestamp (rev_timestamp), INDEX page_timestamp (rev_page,rev_timestamp), INDEX user_timestamp (rev_user,rev_timestamp), - INDEX usertext_timestamp (rev_user_text,rev_timestamp), - INDEX page_user_timestamp (rev_page,rev_user,rev_timestamp) + INDEX usertext_timestamp (rev_user_text,rev_timestamp) ) /*$wgDBTableOptions*/ MAX_ROWS=10000000 AVG_ROW_LENGTH=1024; -- In case tables are created as MyISAM, use row hints for MySQL <5.0 to avoid 4GB limit diff --git a/maintenance/updaters.inc b/maintenance/updaters.inc index dfe970419d..e8fd2061f2 100644 --- a/maintenance/updaters.inc +++ b/maintenance/updaters.inc @@ -1032,8 +1032,6 @@ function do_all_updates( $shared = false, $purge = true ) { do_oldimage_user_index(); flush (); - do_revision_page_user_index(); flush (); - echo "Deleting old default messages (this may take a long time!)..."; flush(); deleteDefaultMessages(); echo "Done\n"; flush(); @@ -1132,17 +1130,6 @@ function do_restrictions_update() { } -function do_revision_page_user_index() { - global $wgDatabase; - if( $wgDatabase->indexExists( 'revision', 'page_user_timestamp' ) ) { - echo "...page,user,timestamp key on revision already exists.\n"; - } else { - echo "Adding page,user,timestamp key on revision table... "; - dbsource( archive("patch-revision-user-page-index.sql"), $wgDatabase ); - echo "ok\n"; - } -} - function pg_describe_table($table) { @@ -1542,4 +1529,4 @@ function do_postgres_updates() { } return; -} +} \ No newline at end of file -- 2.20.1